Improve TextToSpeech function by adding a speech rate parameter#24798
Improve TextToSpeech function by adding a speech rate parameter#24798jfversluis merged 3 commits intodotnet:net10.0from
Conversation
|
@dotnet-policy-service agree |
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
Could you retarget to the net9.0 branch?
| var volume = "default"; | ||
| var pitch = "default"; | ||
| var rate = "default"; | ||
| var rate = "medium"; |
There was a problem hiding this comment.
A bit unrelated but perhaps this is a good opportunity to rename:
src/Essentials/src/TextToSpeech/TextToSpeech.uwp.cs
->
src/Essentials/src/TextToSpeech/TextToSpeech.Windows.cs
as that is the preferred name here. See https://github.com/search?q=repo%3Adotnet%2Fmaui%20.windows.cs&type=code.
I have :) |
|
Can anybody shed some light regarding progress on this feature? |
|
I don't know if I should or can do anything to speed up the process. |
|
Well as i can see they want to target that change to .net9. Since i need to release a stable app at end of the year, |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Unfortunately, I don't know much about the build tasks. Can someone explain to me what the problem is with: Unable to determine the domain name? |
|
Please rebase this on main |
jfversluis
added
area-essentials
|
Sorry this took a while, if you're still interested in getting this merged, please feel free to tag me and see if we can make it happen. Thanks! |
|
Hello @jfversluis , I am still interested in the code being merged. But I still don't know what the problem is. If there is anything I can do, I am happy to do it. |
@Zerod159 I'm not sure what you mean. To move this forward, I believe you need to merge edit: If there is a problem with build or something, feel free to ask. |
|
Indeed can you please rebase on main? |
dotnet-policy-service
bot
added
the
stale
|
I merged my changes to main. what am i doing wrong? |
|
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
1 similar comment
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment was marked as off-topic.
This comment was marked as off-topic.
…eechOptions, allowing for adjustable speaking speed
Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Build succeeded here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10985162&view=results |
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
Awesome, thank you for your very first contribution to .NET MAUI!
|
🚨 API change(s) detected @davidbritch FYI |
7 participants
Description of Change
Added a speech rate parameter to SpeechOptions and implemented the rate on all platforms.
Issues Fixed
Fixed in bug in the Tizen implementation. tts.AddText last Parameter is speed and not pitch. This needs to be options.rate.